Can I make some suggestions?

Atomxy

Posted on 12 May 2009, 01:25:06

Access: Member
Total Posts: 12
Joined: 2009-05-12

Hello everyoneâ€¦ :smile:

My name is Leandro and Iâ€™m from Brazilâ€¦ :laughing:

First I want to say, this is an amazing script, congratulations to developers.

Can I make some suggestions?

Iâ€™m sorry, my English is very bad, but Iâ€™ll try to explainâ€¦

Iâ€™m talking about undefined variables, if the user have â€œerror_reportingâ€ configured to â€œE_ALLâ€, the Php will show a lot of notices, because the undefined variables in all code, and if the user are using a server that donâ€™t gives any access permission to Php.ini file, he don't will be able to change the PHP configuration to hide notices and it makes impossible to still use the script, because the notices fills all the screen.

A simple solutionâ€¦

Code:

If(!isset($variable)) {
$variable = â€˜â€™;
}

In the file config.php, on line 103:

Code:

$smilies .= "<a href=\"javascript:insertsmiley('$row[keycode]');\"><img border=\"0\" src=\"$row[path]\" alt=\"$row[keycode]\"></a> \n";

You need to put a "/" to close img tag, if you don't do this, the script can't be validated in W3C.

Code:

$smilies .= "<a href=\"javascript:insertsmiley('$row[keycode]');\"><img border=\"0\" src=\"$row[path]\" alt=\"$row[keycode]\"/></a> \n";

Except this, N-13 News is a great and very very very good News system.

One more time, congratulations developers.

Thankâ€™s very much for the attention.

Regards

Leandro

#533

Last edited by Atomxy at 2009-05-13 03:37:06 Reason: